Skip to content

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Jun 30, 2019

Successor of #6602, fixes #6463

I've refactored the drone file to use the new syntax of drone 1, which brings several advanteges:

  • multiple pipelines
  • dependencies of steps -> paralle execution of tests

Multiple pipelines:

  • testing: Runs all linters, unit and integration tests
  • translations: Downloads the newest translations from crowdin and also pushes them back to the repo
  • release: cross-compiles releases with xgo and publishes them
  • docs: publishes the docs
  • docker: builds and publishes the docker images
  • notify: triggers the discord notify hook

kolaente added 5 commits June 30, 2019 15:33
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
@kolaente
Copy link
Member Author

kolaente commented Jun 30, 2019

From the parallelization the whole pipeline now takes ~15min instead of 35min for a pr! 🎉

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 30, 2019
kolaente added 6 commits June 30, 2019 16:49
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
@kolaente
Copy link
Member Author

Hmm weired, when I run drone lint locally, it does not complain, only on drone.gitea.io....

kolaente added 3 commits June 30, 2019 17:13
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
@kolaente
Copy link
Member Author

kolaente commented Jun 30, 2019

The translations, release, docker and docs pipelines run even though I specified an exclude condition for prs:

when:
  event:
    exclude:
      - pull_request

I've also tried

when:
  branch:
    - master
  event:
    exclude:
      - pull_request

which didn't work either.

EDIT: I've also tried

when:
  branch:
    - master
  event:
    - push

which didn't work.

@techknowlogick @tboerger @zeripath @lunny @appleboy any ideas?

@kolaente kolaente changed the title Update drone to use drone 1 format WIP: Update drone to use drone 1 format Jun 30, 2019
kolaente added 2 commits June 30, 2019 17:32
Signed-off-by: konrad <konrad@kola-entertainments.de>
Signed-off-by: konrad <konrad@kola-entertainments.de>
@kolaente
Copy link
Member Author

kolaente commented Jun 30, 2019

I've changed the pipeline conditions to use trigger instead and it works now.

Signed-off-by: konrad <konrad@kola-entertainments.de>
@kolaente kolaente changed the title WIP: Update drone to use drone 1 format Update drone to use drone 1 format Jun 30, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@17fa227). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7331   +/-   ##
=========================================
  Coverage          ?   41.24%           
=========================================
  Files             ?      466           
  Lines             ?    63153           
  Branches          ?        0           
=========================================
  Hits              ?    26045           
  Misses            ?    33702           
  Partials          ?     3406

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fa227...d7839be. Read the comment docs.

kolaente added a commit to appleboy/gitea that referenced this pull request Jun 30, 2019
Signed-off-by: konrad <konrad@kola-entertainments.de>
@kolaente
Copy link
Member Author

Closing this in favour of #6602.

@kolaente kolaente closed this Jun 30, 2019
techknowlogick pushed a commit that referenced this pull request Jun 30, 2019
* chore: update drone format to 1.0

* Converted old drone config

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Moved translations to seperate pipeline

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Split the steps in multiple pipelines and add dependencies

Signed-off-by: konrad <konrad@kola-entertainments.de>

* format

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed step depenednecies

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed discord notify

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Exclude translations and docs pipelines from prs

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed exclude prs

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed exclude prs

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Moved releases to seperate pipeline

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Re-trigger drone

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Disable release step

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed depending step

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Adopted dependencies

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Changed pipeline conditions

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Replaced pipeline conditions with triggers

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed coverage step

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Import changes from #7331

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Add comment for lowest go version

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Exclude fetch-tags from prs

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Re-added comment about no tags

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Removed unneeded conditions

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Moved release version and release latest to different pipelines

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed depending pipeline

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Removed the conditions for all services

Signed-off-by: konrad <konrad@kola-entertainments.de>
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
* chore: update drone format to 1.0

* Converted old drone config

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Moved translations to seperate pipeline

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Split the steps in multiple pipelines and add dependencies

Signed-off-by: konrad <konrad@kola-entertainments.de>

* format

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed step depenednecies

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed discord notify

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Exclude translations and docs pipelines from prs

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed exclude prs

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed exclude prs

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Moved releases to seperate pipeline

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Re-trigger drone

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Disable release step

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed depending step

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Adopted dependencies

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Changed pipeline conditions

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Replaced pipeline conditions with triggers

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed coverage step

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Import changes from go-gitea#7331

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Add comment for lowest go version

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Exclude fetch-tags from prs

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Re-added comment about no tags

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Removed unneeded conditions

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Moved release version and release latest to different pipelines

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Fixed depending pipeline

Signed-off-by: konrad <konrad@kola-entertainments.de>

* Removed the conditions for all services

Signed-off-by: konrad <konrad@kola-entertainments.de>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drone 1.0.0 yaml
3 participants