Skip to content

Conversation

Cherrg
Copy link
Contributor

@Cherrg Cherrg commented Jun 29, 2019

remove disabled* ui elements on archived repositories + enable compare button

* by router

full list of changes

  • archived repo - remove
    • open/close button on issue list
    • assigne person on issue list
    • comment field on issue view
    • lock/unlock issue conversation button from sidebar on issue view
    • new pull request button from compare view
  • archived repo - add
    • 'compare commits' button to pull request (as the route is still working, and there is no need for it to be hidden)

fix #7303

Images

Commit 1 Commit 2
grafik grafik
Commit 3
grafik grafik

Cherrg added 3 commits June 29, 2019 01:56
- open/close button on issue list
- assigne person on issue list

Signed-off-by: Michael Gnehr <michael@gnehr.de>
- comment field on issue view
- lock/unlock issue conversation button from sidebar on issue view

Signed-off-by: Michael Gnehr <michael@gnehr.de>
+ remove new pull request button from compare view

as the route is still working, and there is no need to be hidden

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@Cherrg Cherrg changed the title Fix 7303 Fix 7303 - remove unnessesary buttons on archieved repos Jun 29, 2019
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 29, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 29, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e005b5f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7326   +/-   ##
=========================================
  Coverage          ?   41.24%           
=========================================
  Files             ?      464           
  Lines             ?    62867           
  Branches          ?        0           
=========================================
  Hits              ?    25929           
  Misses            ?    33545           
  Partials          ?     3393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e005b5f...d35ad2c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 29, 2019
@Cherrg Cherrg changed the title Fix 7303 - remove unnessesary buttons on archieved repos Fix 7303 - remove unnessesary buttons on archived repos Jun 29, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 29, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2019
@zeripath zeripath merged commit 711f6dc into go-gitea:master Jun 29, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
* archived repo - remove
- open/close button on issue list
- assigne person on issue list

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* archived repo - remove
- comment field on issue view
- lock/unlock issue conversation button from sidebar on issue view

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* archived repo - add 'compare commits' button to pull request

+ remove new pull request button from compare view

as the route is still working, and there is no need to be hidden

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 404 when close issue on archived repo
7 participants