Skip to content

Dark theme fixes #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2019
Merged

Dark theme fixes #7319

merged 2 commits into from
Jun 28, 2019

Conversation

Cherrg
Copy link
Contributor

@Cherrg Cherrg commented Jun 28, 2019 •
edited
Loading

  • add light border to dark theme issue checkboxes, if they are not checked
  • fix jquery datepicker in dark theme, used on milestones
OLD NEW
Issue checkboxes image image
Milestone datepicker image image

Cherrg added 2 commits June 28, 2019 07:28
@Cherrg
add dark theme for jquery xdsoft_datetimepicker
0548c70 
Signed-off-by: Michael Gnehr <michael@gnehr.de>
@Cherrg
add border to dark theme - not checked issue checkboxes
c3d1601 
Signed-off-by: Michael Gnehr <michael@gnehr.de>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@855ebbd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7319   +/-   ##
=========================================
  Coverage          ?   41.24%           
=========================================
  Files             ?      464           
  Lines             ?    62867           
  Branches          ?        0           
=========================================
  Hits              ?    25931           
  Misses            ?    33543           
  Partials          ?     3393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855ebbd...c3d1601. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 28, 2019
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 28, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 28, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2019
richmahn
richmahn approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2019
@zeripath zeripath merged commit 123c703 into go-gitea:master Jun 28, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@Cherrg @jeffliu27
Dark theme fixes (go-gitea#7319)
0301497 
* add dark theme for jquery xdsoft_datetimepicker

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* add border to dark theme - not checked issue checkboxes

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@richmahn richmahn richmahn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Cherrg @codecov-io @lunny @richmahn @techknowlogick @zeripath @GiteaBot