Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 8, 2019

As title

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 8, 2019
@lafriks
Copy link
Member

lafriks commented Jul 8, 2019

Unit test still fails (close date)

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5f8f42e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7375   +/-   ##
=========================================
  Coverage          ?   41.18%           
=========================================
  Files             ?      469           
  Lines             ?    63535           
  Branches          ?        0           
=========================================
  Hits              ?    26170           
  Misses            ?    33945           
  Partials          ?     3420

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f8f42e...ba255d3. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 8, 2019
@lafriks lafriks merged commit 427a161 into go-gitea:master Jul 8, 2019
@lunny lunny deleted the lunny/fix_tests branch July 8, 2019 13:19
lunny added a commit to lunny/gitea that referenced this pull request Jul 8, 2019
* fix migration tests since #7 fixed

* fix test time
lunny added a commit that referenced this pull request Jul 8, 2019
* fix migration tests since #7 fixed

* fix test time
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
* fix migration tests since go-gitea#7 fixed

* fix test time
@lafriks lafriks added the backport/done All backports for this PR have been created label Jul 31, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants