Skip to content

Detect migrating batch size #7353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2019
Merged

Detect migrating batch size #7353

merged 4 commits into from
Jul 6, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 4, 2019 •
edited
Loading

should fix #7348

@lunny lunny added the type/enhancement An improvement of existing functionality label Jul 4, 2019
@lunny lunny mentioned this pull request Jul 4, 2019
Closed
@zeripath
Copy link
Contributor

zeripath commented Jul 4, 2019

Does a batch size of 100 work by default for sqlite?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 4, 2019
@lunny
Copy link
Member Author

lunny commented Jul 4, 2019

@zeripath it works for me but not @mrsdizzie

@mrsdizzie
Copy link
Member

I left comment on #7348 about the size

@lunny lunny force-pushed the lunny/migrate_batch_size branch from 9a374af to 2db9303 Compare July 6, 2019 16:30
@lunny lunny changed the title Make migrating batch size as configurable Detect migrating batch size Jul 6, 2019
@codecov-io
Copy link

codecov-io commented Jul 6, 2019 •
edited
Loading

Codecov Report

Merging #7353 into master will decrease coverage by 0.01%.
The diff coverage is 14.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7353      +/-   ##
==========================================
- Coverage   41.24%   41.23%   -0.02%     
==========================================
  Files         467      467              
  Lines       63295    63336      +41     
==========================================
+ Hits        26108    26117       +9     
- Misses      33770    33803      +33     
+ Partials     3417     3416       -1
Impacted Files Coverage Δ
models/models.go 58.02% <100%> (+0.52%) ⬆️
modules/migrations/gitea.go 8.59% <26.66%> (+0.81%) ⬆️
modules/migrations/migrate.go 19.2% <4.65%> (-1.58%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef57fe4...3b0dc3a. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 6, 2019
@mrsdizzie
Copy link
Member

This looks good thanks! Was able to migrate all Gitea with Sqlite

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 6, 2019
@zeripath
Copy link
Contributor

zeripath commented Jul 6, 2019

I guess this needs to be 1.9

@mrsdizzie
Copy link
Member

Yes should be in 1.9 since the batch processing is

@techknowlogick techknowlogick added this to the 1.9.0 milestone Jul 6, 2019
@techknowlogick techknowlogick merged commit 337d691 into go-gitea:master Jul 6, 2019
@lunny lunny deleted the lunny/migrate_batch_size branch July 7, 2019 00:40
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Detect migrating batch size (go-gitea#7353)
4c86c92 
* Make migrating batch size as configurable

* detect different table batch insert size and remove config item

* remove unrelated changes
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

New batch migration causes error on sqlite
6 participants
@lunny @zeripath @mrsdizzie @codecov-io @techknowlogick @GiteaBot