update npm dependencies and various tweaks #7344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ran `make npm-update` - ran `make js`, fixed new lint issue - ran `make css`, this added back some vendor prefixes - added `engines` property to package.json to specify minimum required Node.js version - added `private` property to package.json to prevent accidential publishing to npm
silverwind
commented
Jul 2, 2019
| .tab-size-13{-moz-tab-size:13!important;-o-tab-size:13!important;tab-size:13!important} | ||
| .tab-size-14{-moz-tab-size:14!important;-o-tab-size:14!important;tab-size:14!important} | ||
| .tab-size-15{-moz-tab-size:15!important;-o-tab-size:15!important;tab-size:15!important} | ||
| .tab-size-16{-moz-tab-size:16!important;-o-tab-size:16!important;tab-size:16!important} |
There was a problem hiding this comment.
@zeripath they are back again, and should hopefully stay now that we lock dependencies.
zeripath
approved these changes
Jul 2, 2019
sapk
approved these changes
Jul 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #7344 +/- ##
==========================================
- Coverage 41.25% 41.25% -0.01%
==========================================
Files 467 467
Lines 63291 63291
==========================================
- Hits 26113 26108 -5
- Misses 33762 33767 +5
Partials 3416 3416
Continue to review full report at Codecov.
|
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
- ran `make npm-update` - ran `make js`, fixed new lint issue - ran `make css`, this added back some vendor prefixes - added `engines` property to package.json to specify minimum required Node.js version - added `private` property to package.json to prevent accidential publishing to npm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make npm-updatemake js, fixed new lint issuemake css, this added back some vendor prefixesenginesproperty to package.json to specify minimum required Node.js versionprivateproperty to package.json to prevent accidential publishing to npm