Skip to content

Only check and config git on web subcommand but not others #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2019
Merged

Only check and config git on web subcommand but not others #7236

merged 3 commits into from
Jun 19, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 18, 2019

This will remove git config and check from serv and hooks subcommands but only for web command. Should fix #7075

@lunny lunny added the type/bug label Jun 18, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 18, 2019
@lunny lunny force-pushed the lunny/git_config_quotepath branch from a923510 to e7c0292 Compare June 18, 2019 14:19
@lunny lunny force-pushed the lunny/git_config_quotepath branch from e7c0292 to 681a0ed Compare June 19, 2019 01:44
@codecov-io
Copy link

codecov-io commented Jun 19, 2019 •
edited
Loading

Codecov Report

Merging #7236 into master will increase coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7236      +/-   ##
==========================================
+ Coverage   40.97%   40.99%   +0.02%     
==========================================
  Files         462      462              
  Lines       62585    62578       -7     
==========================================
+ Hits        25646    25656      +10     
+ Misses      33578    33559      -19     
- Partials     3361     3363       +2
Impacted Files Coverage Δ
cmd/serv.go 0% <ø> (ø) ⬆️
routers/init.go 65.33% <0%> (-2.73%) ⬇️
modules/git/git.go 39.39% <40%> (+6.06%) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71cabb...6e2dee0. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 19, 2019
zeripath
zeripath approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I left these in. Yes we no longer need these as git serv and git hook no longer do anything directly.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2019
@lafriks lafriks merged commit 8ec6597 into go-gitea:master Jun 19, 2019
@lunny lunny deleted the lunny/git_config_quotepath branch June 20, 2019 00:33
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Only check and config git on web subcommand but not others (go-gitea#…
97301e5 
…7236)

* only check and config git on web subcommand but not others

* add Init in git tests
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Sometimes CI report panic
6 participants
@lunny @codecov-io @mrsdizzie @zeripath @lafriks @GiteaBot