Enable tls-alpn-01: Use certmanager provided TLSConfig for LetsEncrypt #7229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
f3dde07 to
6091066
Compare
|
As this isn't a bugfix it shouldn't be backported. |
techknowlogick
approved these changes
Jun 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #7229 +/- ##
==========================================
- Coverage 41.53% 41.52% -0.01%
==========================================
Files 449 449
Lines 61344 61344
==========================================
- Hits 25478 25476 -2
- Misses 32511 32513 +2
Partials 3355 3355
Continue to review full report at Codecov.
|
adelowo
approved these changes
Jun 17, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use the certmanager provided TLSConfig for LetsEncrypt we get tls-alpn-01 for free allowing people to deploy gitea without http access.