Skip to content

Conversation

sapk
Copy link
Member

@sapk sapk commented Jun 15, 2019

We don't need to require the same running user for internal SSH (like on windows platform)

This PR is needed if we want #7129 to be (container running) user independant.

@sapk sapk mentioned this pull request Jun 15, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #7215 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7215      +/-   ##
==========================================
- Coverage   41.52%   41.52%   -0.01%     
==========================================
  Files         449      449              
  Lines       61310    61310              
==========================================
- Hits        25460    25457       -3     
- Misses      32496    32501       +5     
+ Partials     3354     3352       -2
Impacted Files Coverage Δ
modules/setting/setting.go 48.95% <100%> (+0.17%) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde4105...4446689. Read the comment docs.

@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 16, 2019
@lunny lunny merged commit 273f199 into go-gitea:master Jun 16, 2019
@sapk sapk deleted the dont-enforce-same-user-for-internal branch June 16, 2019 07:09
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 17, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants