Skip to content

Only warn on errors in deleting LFS orphaned files during repo deletion #7213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2019
Merged

Only warn on errors in deleting LFS orphaned files during repo deletion #7213

merged 2 commits into from
Jun 15, 2019

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jun 15, 2019 •
edited
Loading

Fixes #3272

@zeripath zeripath added this to the 1.9.0 milestone Jun 15, 2019
@codecov-io
Copy link

codecov-io commented Jun 15, 2019 •
edited
Loading

Codecov Report

Merging #7213 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7213      +/-   ##
==========================================
+ Coverage   41.51%   41.52%   +<.01%     
==========================================
  Files         449      449              
  Lines       61313    61310       -3     
==========================================
+ Hits        25457    25460       +3     
+ Misses      32504    32497       -7     
- Partials     3352     3353       +1
Impacted Files Coverage Δ
models/admin.go 81.63% <0%> (ø) ⬆️
models/repo.go 48.35% <0%> (+0.07%) ⬆️
models/gpg_key.go 55.83% <0%> (-0.84%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0323122...ccb79dc. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 15, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 15, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2019
@zeripath zeripath merged commit cde4105 into go-gitea:master Jun 15, 2019
@zeripath zeripath deleted the remove-lfs-files-with-notice-during-repo-deletion branch June 15, 2019 22:20
@zeripath zeripath mentioned this pull request Jun 22, 2019
Closed
7 tasks
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@zeripath @jeffliu27
Only warn on errors in deleting LFS orphaned files during repo deleti…
c1e575c 
…on (go-gitea#7213)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+2 more reviewers

@sapk sapk sapk approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Delete all repository records which are missing their Git files - does not work
6 participants
@zeripath @codecov-io @lunny @sapk @adelowo @GiteaBot