Skip to content

Conversation

mrsdizzie
Copy link
Member

Include the directory in name when looking for matching Submodule from .gitmodules file

Fixes #7262

Include the directory in name when looking for matching Submodule from
.gitmodules file

Fixes go-gitea#7262
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sincerely wish we'd insisted on always returning the full name from the git entry functions. Bugs like this would not be able to sneak in.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 21, 2019
@codecov-io
Copy link

Codecov Report

Merging #7275 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7275      +/-   ##
==========================================
- Coverage   40.99%   40.98%   -0.01%     
==========================================
  Files         462      462              
  Lines       62578    62584       +6     
==========================================
- Hits        25654    25652       -2     
- Misses      33562    33570       +8     
  Partials     3362     3362
Impacted Files Coverage Δ
modules/git/commit_info.go 69.81% <0%> (-2.74%) ⬇️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db4541...0ee662c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 21, 2019
@lunny lunny merged commit a25b3d4 into go-gitea:master Jun 21, 2019
@lunny
Copy link
Member

lunny commented Jun 21, 2019

Please send back port to v1.8

@mrsdizzie
Copy link
Member Author

@lunny this file was previously part of go-gitea/git which has now been archived. If you want to unarchive I could send a PR, but maybe not necessary if we are going to try and release 1.9 soon

@lunny
Copy link
Member

lunny commented Jun 21, 2019

OK.

jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
Include the directory in name when looking for matching Submodule from
.gitmodules file

Fixes go-gitea#7262
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submodule link can only work at root
5 participants