Skip to content

Fix error log when loading issues caused by a xorm bug #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 23, 2019
Merged

Fix error log when loading issues caused by a xorm bug #7271

merged 5 commits into from
Jun 23, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 20, 2019 •
edited
Loading

Before this PR, when rows.Close, xorm always complained sql: no rows, that has been fixed on go-xorm/xorm#1334. This PR will fix that wrong error log.

And this will upgrade xorm, mssql, mysql packages

@lunny lunny added the type/bug label Jun 20, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 20, 2019
@lunny lunny force-pushed the lunny/fix_rows_err branch from 9078856 to 02a91a9 Compare June 22, 2019 07:18
zeripath
zeripath reviewed Jun 22, 2019
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 22, 2019
@lunny lunny force-pushed the lunny/fix_rows_err branch from 02a91a9 to 5f6ebcf Compare June 23, 2019 01:18
@codecov-io
Copy link

Codecov Report

Merging #7271 into master will decrease coverage by <.01%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7271      +/-   ##
==========================================
- Coverage   41.17%   41.17%   -0.01%     
==========================================
  Files         464      464              
  Lines       62771    62761      -10     
==========================================
- Hits        25846    25839       -7     
+ Misses      33537    33528       -9     
- Partials     3388     3394       +6
Impacted Files Coverage Δ
models/models.go 57.5% <ø> (ø) ⬆️
models/review.go 53.08% <ø> (ø) ⬆️
models/issue_tracked_time.go 67.56% <ø> (ø) ⬆️
models/migrations/v38.go 0% <ø> (ø) ⬆️
models/repo_list.go 73.09% <ø> (ø) ⬆️
models/org.go 69.12% <ø> (ø) ⬆️
models/issue_comment.go 47.59% <ø> (ø) ⬆️
models/migrations/v78.go 0% <ø> (ø) ⬆️
models/log.go 41.86% <ø> (ø) ⬆️
models/repo_unit.go 64.91% <ø> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baefea3...b7b2d67. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 23, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 23, 2019
@lafriks lafriks merged commit aa7c34c into go-gitea:master Jun 23, 2019
@lunny lunny deleted the lunny/fix_rows_err branch June 24, 2019 02:18
@lunny lunny mentioned this pull request Jun 26, 2019
Closed
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Fix error log when loading issues caused by a xorm bug (go-gitea#7271)
f0273f8 
* fix error log when loading issues caused by a xorm bug

* upgrade packages

* fix fmt

* fix Consistency

* fix tests
@6543 6543 mentioned this pull request Nov 15, 2019
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+2 more reviewers

@zeripath zeripath zeripath left review comments

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @lafriks @zeripath @sapk @GiteaBot