Skip to content

Add .fa icon margin like .octicon #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

Add .fa icon margin like .octicon #7258

merged 1 commit into from
Jun 20, 2019

Conversation

sapk
Copy link
Member

@sapk sapk commented Jun 20, 2019

A little margin is missing for fa icon like openid on this example.
This PR simply duplicate the rule applied on .octicon to .fa

Before

before

After

after

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 20, 2019
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 20, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #7258 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7258      +/-   ##
==========================================
+ Coverage   40.99%   40.99%   +<.01%     
==========================================
  Files         462      462              
  Lines       62578    62578              
==========================================
+ Hits        25651    25654       +3     
+ Misses      33566    33561       -5     
- Partials     3361     3363       +2
Impacted Files Coverage Δ
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec6597...a95aebe. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2019
@lunny lunny merged commit de9b398 into go-gitea:master Jun 20, 2019
@lunny
Copy link
Member

lunny commented Jun 20, 2019

Could you send back port to v1.8 ?

@sapk sapk mentioned this pull request Jun 20, 2019
Merged
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@sapk @jeffliu27
add .fa margin like .octicon (go-gitea#7258)
cba2575
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sapk @codecov-io @lunny @techknowlogick @zeripath @GiteaBot