Add LastLogin to the User API #7196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7196 +/- ##
==========================================
- Coverage 41.52% 41.52% -0.01%
==========================================
Files 449 449
Lines 61310 61314 +4
==========================================
Hits 25461 25461
- Misses 32497 32501 +4
Partials 3352 3352
Continue to review full report at Codecov.
|
5 tasks
|
will fix #7197 |
sapk
approved these changes
Jun 15, 2019
|
It maybe good to add at least small test to: Line 26 in 8cd4c22 |
lunny
approved these changes
Jun 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the LastLogin to the API returns for
/api/v1/user/api/v1/users/:usernameand/api/v1/admin/users