Skip to content

Revert "Make modules/structs as a separate go mod" #7175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2019
Merged

Revert "Make modules/structs as a separate go mod" #7175

merged 1 commit into from
Jun 10, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 10, 2019

Reverts #7127

I think I'm wrong making a sub folder as a separate go mod will make PR merging difficult.

@saitho
Copy link
Contributor

saitho commented Jun 10, 2019

Currently CI fails because the mod files weren't updated in or after #7127 was merged.
If we're reverting this change we should do so ASAP. ;) Also that would probably mean reopening go-gitea/go-sdk#177.
If we're not reverting this change anytime soon we should update the files using make vendor to enable working builds again.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2019
@lunny
Copy link
Member Author

lunny commented Jun 10, 2019

@saitho make vendor will save code.gitea.io/gita/modules/structs on vendor. That's not a good idea.

@saitho
Copy link
Contributor

saitho commented Jun 10, 2019 •
edited
Loading

@saitho make vendor will save code.gitea.io/gita/modules/structs on vendor. That's not a good idea.

At least that's what its telling me to do in the failing Drone build for #7171. ^^

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2019
@techknowlogick techknowlogick merged commit b3b4684 into master Jun 10, 2019
@techknowlogick techknowlogick deleted the revert-7127-lunny/structs_as_mod branch June 10, 2019 19:56
@lunny
Copy link
Member Author

lunny commented Jun 11, 2019

This reopened https://gitea.com/gitea/go-sdk/issues/177

@zeripath zeripath added this to the 1.9.0 milestone Jul 6, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Revert "make modules/structs as a spereate go mod (go-gitea#7127)" (g…
e634450 
…o-gitea#7175)

This reverts commit 835b53f.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@saitho saitho saitho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @saitho @techknowlogick @lafriks @zeripath @GiteaBot