Skip to content

If milestone id is zero don't get it from database #7169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2019
Merged

If milestone id is zero don't get it from database #7169

merged 2 commits into from
Jun 10, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 10, 2019

As title.

@lunny lunny added this to the 1.9.0 milestone Jun 10, 2019
@codecov-io
Copy link

codecov-io commented Jun 10, 2019 •
edited
Loading

Codecov Report

Merging #7169 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7169      +/-   ##
==========================================
- Coverage   41.75%   41.73%   -0.03%     
==========================================
  Files         449      449              
  Lines       61111    61112       +1     
==========================================
- Hits        25515    25503      -12     
- Misses      32281    32297      +16     
+ Partials     3315     3312       -3
Impacted Files Coverage Δ
routers/repo/issue.go 35.6% <0%> (-0.28%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/issue_milestone.go 57.69% <0%> (-1.48%) ⬇️
models/error.go 32.08% <0%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93e623...26674f2. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2019
@lunny lunny merged commit 7162fbf into go-gitea:master Jun 10, 2019
@lunny lunny deleted the lunny/fix_milestone_issue branch June 10, 2019 14:16
@lunny lunny mentioned this pull request Jun 10, 2019
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jun 10, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
if milestone id is zero don't get it from database (go-gitea#7169)
d94090a
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @techknowlogick @adelowo @GiteaBot