Skip to content

Fix wrong init dependency on markup extensions #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 25, 2019
Merged

Fix wrong init dependency on markup extensions #7038

merged 4 commits into from
May 25, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 25, 2019

This will fix the bug that markdown parser has been initialized before customerize markdown extensions load.

@lunny lunny added this to the 1.9.0 milestone May 25, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 25, 2019
@lafriks
Copy link
Member

lafriks commented May 25, 2019

Tests fail

@lunny lunny force-pushed the lunny/fix_markup_init branch from b7fc649 to e04058c Compare May 25, 2019 09:57
@codecov-io
Copy link

codecov-io commented May 25, 2019 •
edited
Loading

Codecov Report

Merging #7038 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7038      +/-   ##
==========================================
- Coverage   41.49%   41.46%   -0.04%     
==========================================
  Files         441      442       +1     
  Lines       59526    59597      +71     
==========================================
+ Hits        24700    24709       +9     
- Misses      31597    31658      +61     
- Partials     3229     3230       +1
Impacted Files Coverage Δ
modules/markup/markup.go 81.15% <100%> (+2.12%) ⬆️
routers/init.go 68.49% <100%> (+0.43%) ⬆️
modules/log/colors_router.go 83.33% <0%> (-4.17%) ⬇️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️
modules/markup/external/external.go 1.58% <0%> (ø)
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c432d2...e7f27cf. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented May 25, 2019

@lafriks fixed

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 25, 2019
@zeripath zeripath changed the title Fix wrong init dependency on markup extersions Fix wrong init dependency on markup extensions May 25, 2019
@zeripath zeripath merged commit 355ab0c into go-gitea:master May 25, 2019
@lunny lunny deleted the lunny/fix_markup_init branch May 26, 2019 00:51
@lafriks
Copy link
Member

lafriks commented May 29, 2019

@lunny please send backport

lunny added a commit to lunny/gitea that referenced this pull request May 29, 2019
@lunny
Fix wrong init dependency on markup extensions (go-gitea#7038)
2c3bb1e 
* fix wrong init dependency on markup extensions
@lunny lunny mentioned this pull request May 29, 2019
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 29, 2019
techknowlogick pushed a commit that referenced this pull request May 29, 2019
@lunny @techknowlogick
Fix wrong init dependency on markup extensions (#7038) (#7074)
31ad8b7 
* fix wrong init dependency on markup extensions
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Fix wrong init dependency on markup extensions (go-gitea#7038)
824dd00 
* fix wrong init dependency on markup extensions
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @lafriks @codecov-io @zeripath @techknowlogick @GiteaBot