Improve handling of non-square avatars #7025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to run make vendor and commit |
|
Committed the change to modules.txt but the build still seems to be failing |
|
You haven't run make vendor and committed |
Codecov Report
@@ Coverage Diff @@
## master #7025 +/- ##
=========================================
Coverage ? 41.48%
=========================================
Files ? 441
Lines ? 59526
Branches ? 0
=========================================
Hits ? 24696
Misses ? 31603
Partials ? 3227
Continue to review full report at Codecov.
|
lafriks
approved these changes
May 24, 2019
zeripath
approved these changes
May 24, 2019
lunny
requested changes
May 24, 2019
modules/avatar/avatar.go
Outdated
| @@ -5,9 +5,15 @@ | |||
| package avatar | |||
|
|
|||
| import ( | |||
| "bytes" | |||
| "code.gitea.io/gitea/modules/setting" | |||
| @@ -7,7 +7,9 @@ package avatar | |||
| import ( | |||
| "testing" | |||
|
|
|||
| "code.gitea.io/gitea/modules/setting" | |||
Signed-off-by: Rob Watson <rfwatson@users.noreply.github.com>
Signed-off-by: Rob Watson <rfwatson@users.noreply.github.com>
Merged
lunny
approved these changes
May 25, 2019
7 tasks
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* Crop avatar before resizing (go-gitea#1268) Signed-off-by: Rob Watson <rfwatson@users.noreply.github.com> * Fix spelling error Signed-off-by: Rob Watson <rfwatson@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crop avatars before resizing them. This prevents a user's first experience of Gitea being a nasty aspect ratio on their avatar.
Before
After
Discussion points
Questions
CI failing due to the missinggithub.com/oliamb/cutterdependency - how should this be included/packaged? Go newbie here so advice/help welcome.