~~Looking at the code I think these two settings need to be coalesced. It doesn't appear that DEFAULT_ALLOW_CREATE_ORGANIZATION is wired into anything at all. ~~

We should probably just kill DEFAULT_ALLOW_CREATE_ORGANIZATION let's just rewire it back in and fix the test

I can certainly do that as well. Should there be a warning if somebody has it set in the config file? Is there a place to add a message to, so it will end up in the release notes?

Hmm... let's just fix the test. I think that's the correct thing to do.

Make line 263:

setting.Service.DefaultAllowCreateOrganization = true

I ran the drone test locally before creating this pull request. It seems the test did not fail for me. What did I do wrong? The output can be found here: https://gist.github.com/jpicht/6337485ab466776fded3ee22089d45dc

You didn't run the unit tests - that is make test - your logs indicate you only ran the integration tests

Codecov Report

Merging #7017 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7017      +/-   ##
==========================================
- Coverage    41.5%   41.48%   -0.02%     
==========================================
  Files         440      440              
  Lines       59453    59452       -1     
==========================================
- Hits        24675    24663      -12     
- Misses      31558    31570      +12     
+ Partials     3220     3219       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb53ac...7301c69. Read the comment docs.

You didn't run the unit tests - that is make test - your logs indicate you only ran the integration tests

Thanks! That step should probably be added to the contributors guide.

Make lgtm work

Please send backport to release/v1.8 branch