Skip to content

SearchRepositoryByName improvements and unification (#6897) #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2019
Merged

SearchRepositoryByName improvements and unification (#6897) #7002

merged 5 commits into from
May 21, 2019

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 20, 2019 •
edited
Loading

Backport #6897, should fix #7001

@lafriks lafriks requested a review from zeripath May 20, 2019 13:35
@lafriks lafriks added this to the 1.8.2 milestone May 20, 2019
zeripath
zeripath reviewed May 20, 2019
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 20, 2019
zeripath
zeripath reviewed May 20, 2019
View reviewed changes
zeripath
zeripath reviewed May 20, 2019
View reviewed changes
zeripath
zeripath reviewed May 20, 2019
View reviewed changes
@zeripath
Copy link
Contributor

I was literally just doing this... 2 public repos were added between 1.9 and 1.8 so you need to change a few numbers in the test cases.

@zeripath
Copy link
Contributor

Probably will need @mrsdizzie 's additional fix for collaborators on team repositories.

@mrsdizzie
Copy link
Member

mrsdizzie commented May 20, 2019 •
edited
Loading

That was already back ported in #6968 and so things should just work when this change starts listing those repos in a users dashboard

lafriks and others added 4 commits May 20, 2019 21:11
@lafriks @zeripath
Update tests
b8dd1bf 
Co-Authored-By: zeripath <art27@cantab.net>
@lafriks @zeripath
Update tests
32cb7b7 
Co-Authored-By: zeripath <art27@cantab.net>
@lafriks @zeripath
Update tests
545caab 
Co-Authored-By: zeripath <art27@cantab.net>
@lafriks
Fix tests
13760ed
@zeripath
Copy link
Contributor

Make lg-tm work

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2019
@lafriks lafriks merged commit 608f46e into go-gitea:release/v1.8 May 21, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lafriks @zeripath @mrsdizzie @GiteaBot