Validate External Tracker URL Format #7089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some validation checks for external tracker URL format. Fixes go-gitea#7068
Codecov Report
@@ Coverage Diff @@
## master #7089 +/- ##
==========================================
+ Coverage 41.72% 41.74% +0.02%
==========================================
Files 443 443
Lines 60149 60158 +9
==========================================
+ Hits 25095 25112 +17
+ Misses 31778 31769 -9
- Partials 3276 3277 +1
Continue to review full report at Codecov.
|
adelowo
suggested changes
May 30, 2019
adelowo
reviewed
May 30, 2019
adelowo
approved these changes
May 30, 2019
lunny
approved these changes
May 31, 2019
techknowlogick
approved these changes
May 31, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* Validate External Tracker URL Format Add some validation checks for external tracker URL format. Fixes go-gitea#7068 * Don't make {index} a hard requirement * Fix Description * make fmt * move regex to package level * fix copyright date
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some validation checks for external tracker URL format.
Attempts to check for simple typos by making sure there is a matching open/close brace for placeholder variable names if the opposite is present.
Fixes #7068