Skip to content

Conversation

zeripath
Copy link
Contributor

This PR is a partial breakout from #6993 and refactors git_test.go to remove most the duplicated code in this test and additionally tests protected branch merging.

* Ensure that the lfs files are created with a different prefix
* Reduce the replication in git_test.go
* Remove unnecessary "/"
@zeripath zeripath added this to the 1.9.0 milestone May 30, 2019
@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #7086 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7086      +/-   ##
==========================================
+ Coverage   41.73%   41.85%   +0.12%     
==========================================
  Files         443      443              
  Lines       60158    60158              
==========================================
+ Hits        25104    25181      +77     
+ Misses      31778    31687      -91     
- Partials     3276     3290      +14
Impacted Files Coverage Δ
models/issue.go 48.34% <0%> (+0.23%) ⬆️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
modules/base/tool.go 73.8% <0%> (+1.25%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️
routers/repo/setting_protected_branch.go 42.01% <0%> (+1.77%) ⬆️
routers/api/v1/repo/pull.go 37.89% <0%> (+1.83%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️
models/branches.go 51.33% <0%> (+8%) ⬆️
modules/util/compare.go 54.54% <0%> (+9.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6ef14...79b5f3c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2019
@zeripath zeripath merged commit fb4438a into go-gitea:master May 31, 2019
@zeripath zeripath deleted the refactor-git-test branch May 31, 2019 10:12
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
* Ensure that the lfs files are created with a different prefix
* Reduce the replication in git_test.go
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants