improve github downloader on migrations #7049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7049 +/- ##
==========================================
+ Coverage 41.72% 41.74% +0.02%
==========================================
Files 443 443
Lines 60159 60149 -10
==========================================
+ Hits 25103 25112 +9
+ Misses 31780 31762 -18
+ Partials 3276 3275 -1
Continue to review full report at Codecov.
|
lafriks
reviewed
May 26, 2019
modules/migrations/git.go
Outdated
| func (g *PlainGitDownloader) GetIssues(start, limit int) ([]*base.Issue, error) { | ||
| return nil, ErrNotSupported | ||
| // GetIssues returns issues according page and PerPage | ||
| func (g *PlainGitDownloader) GetIssues(page, PerPage int) ([]*base.Issue, bool, error) { |
There was a problem hiding this comment.
pageSize would be better name imho
Suggested change
| func (g *PlainGitDownloader) GetIssues(page, PerPage int) ([]*base.Issue, bool, error) { | |
| func (g *PlainGitDownloader) GetIssues(page, pageSize int) ([]*base.Issue, bool, error) { |
There was a problem hiding this comment.
The name is from github's API document. :)
There was a problem hiding this comment.
Method argument then should be at least lowercase first letter
bd1fe0e to
95781d7
Compare
|
@lafriks done. |
lafriks
approved these changes
May 29, 2019
adelowo
approved these changes
May 30, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* improve github downloader on migrations * fix tests * fix uppercase function parameters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new interface will make code easier to understand.