Fix charset was not saved after installation finished #7048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7048 +/- ##
==========================================
+ Coverage 41.45% 41.45% +<.01%
==========================================
Files 442 442
Lines 59608 59610 +2
==========================================
+ Hits 24708 24709 +1
- Misses 31670 31672 +2
+ Partials 3230 3229 -1
Continue to review full report at Codecov.
|
zeripath
approved these changes
May 26, 2019
adelowo
approved these changes
May 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #6992, we introduced
CHARSETondatabaseseciton to app.ini. But unfortunately, I missed to saveCHARSETtoapp.iniafter installation finished. This PR will fix that.