Skip to content

When git version >= 2.18, git command could run with git wire protocol version 2 param if enabled #7047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2019
Merged

When git version >= 2.18, git command could run with git wire protocol version 2 param if enabled #7047

merged 2 commits into from
May 26, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 26, 2019

This PR will accelerate many git operations with remotes, especial migrations and mirrors.

@lunny lunny added the type/enhancement An improvement of existing functionality label May 26, 2019
@lunny lunny added this to the 1.9.0 milestone May 26, 2019
@codecov-io
Copy link

codecov-io commented May 26, 2019 •
edited
Loading

Codecov Report

Merging #7047 into master will decrease coverage by 0.02%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7047      +/-   ##
==========================================
- Coverage   41.46%   41.44%   -0.03%     
==========================================
  Files         442      442              
  Lines       59597    59604       +7     
==========================================
- Hits        24714    24704      -10     
- Misses      31654    31670      +16     
- Partials     3229     3230       +1
Impacted Files Coverage Δ
modules/setting/git.go 52.17% <44.44%> (-10.33%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 42.02% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c16feb...dda8ba4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 26, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 26, 2019
@lunny lunny merged commit 063fa99 into go-gitea:master May 26, 2019
@lunny lunny deleted the lunny/client_git_ver2 branch May 26, 2019 09:50
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
when git version >= 2.18, git command could run with git wire protoco…
35f1622 
…l version 2 param if enabled (go-gitea#7047)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @techknowlogick @zeripath @GiteaBot