Handle insecure and ports in go get #7041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7041 +/- ##
==========================================
- Coverage 41.46% 41.45% -0.01%
==========================================
Files 442 442
Lines 59611 59623 +12
==========================================
+ Hits 24715 24716 +1
- Misses 31665 31676 +11
Partials 3231 3231
Continue to review full report at Codecov.
|
lafriks
requested changes
May 25, 2019
lunny
requested changes
May 26, 2019
lunny
approved these changes
May 26, 2019
lafriks
reviewed
May 27, 2019
zeripath
commented
May 27, 2019
zeripath
commented
May 27, 2019
zeripath
commented
May 27, 2019
zeripath
commented
May 27, 2019
lafriks
approved these changes
May 27, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* Handle insecure and ports in go get * Fix IsExternalURL for non-standard ports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a gitea running on non-standard port is listed as the location for a go mod file, go will fail to get it as the port is not listed and for HTTP the --insecure flag is not set. This PR applies these changes.
Fixes #6985
Also fixes a similar unreported bug in url.IsExternalURL on non-standard ports.