Skip to content

Update xorm and fix dump command #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2017
Merged

Update xorm and fix dump command #692

merged 5 commits into from
Jan 23, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 18, 2017

This will resolve #686

@lunny lunny added the type/bug label Jan 18, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 18, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 18, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jan 20, 2017

@lunny I don't see how this "fixes" #686. It only fails when there's an error, it doesn't fix the error itself?

@lunny
Copy link
Member Author

lunny commented Jan 20, 2017

The mainly bug is in XORM. When dump from Sqlite to Postgres, the bool type transform was not corrected.

@bkcsoft
Copy link
Member

bkcsoft commented Jan 21, 2017

LGTM

Bwko
Bwko reviewed Jan 21, 2017
View reviewed changes
vendor/vendor.json
"path": "github.com/go-xorm/xorm",
"revision": "44b70cccf417e3d4a565aaa3128853b5cd553767",
"revisionTime": "2017-01-03T05:31:47Z"
"revision": "263f9d3fa5d9ce24069ffdc9486c58e370f4f707",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunny This should be go-xorm/xorm@c360c20

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Bwko
Copy link
Member

Bwko commented Jan 21, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2017
@mjwwit
Copy link
Contributor

mjwwit commented Jan 23, 2017

Tested by migrating a sizable production instance from SQLite3 to Postgres, and it worked like a charm!

@lunny lunny merged commit a8048c1 into go-gitea:master Jan 23, 2017
@lunny lunny deleted the lunny/fix_dump branch April 19, 2017 05:45
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@Bwko Bwko Bwko left review comments

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Gitea dump not working
6 participants
@lunny @appleboy @bkcsoft @Bwko @mjwwit @tboerger