Skip to content

Fix code overflow #6914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2019
Merged

Fix code overflow #6914

merged 2 commits into from
May 14, 2019

Conversation

xf-
Copy link
Contributor

@xf- xf- commented May 11, 2019

Fix #6769

format code like log setting and ensure it breaks on small screens
image

image

@xf- xf- force-pushed the bugfix/adminCode branch from 2e16614 to c6ed391 Compare May 11, 2019 22:49
@codecov-io
Copy link

codecov-io commented May 11, 2019 •
edited
Loading

Codecov Report

Merging #6914 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6914      +/-   ##
==========================================
- Coverage    41.4%   41.39%   -0.01%     
==========================================
  Files         441      441              
  Lines       59732    59732              
==========================================
- Hits        24734    24729       -5     
- Misses      31758    31764       +6     
+ Partials     3240     3239       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.02% <0%> (-1.02%) ⬇️
modules/log/colors_router.go 87.5% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55c874...2a39399. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 11, 2019
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label May 12, 2019
@lunny lunny added this to the 1.9.0 milestone May 12, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 12, 2019
@lafriks
Copy link
Member

lafriks commented May 12, 2019

Conflict

@xf-
Copy link
Contributor Author

xf- commented May 12, 2019

@lafriks you want to merge this next? A compressed - single line css will always cause conflicts. i will rebase it. Maybe set less to single line per selector - less conflicts with multiple css changes

@xf- xf- force-pushed the bugfix/adminCode branch from c6ed391 to c89f53d Compare May 13, 2019 19:47
@kolaente
Copy link
Member

@xf- You need to run make generate-stylesheets to create a new compiled stylesheet with your changes. We always keep the comiled less in the repo.

@xf-
Copy link
Contributor Author

xf- commented May 13, 2019 •
edited
Loading

@kolaente forgot it while rebasing all branches

lafriks
lafriks reviewed May 13, 2019
View reviewed changes
@xf- xf- force-pushed the bugfix/adminCode branch from e1fbc7f to de3ce05 Compare May 13, 2019 22:52
@xf-
Copy link
Contributor Author

xf- commented May 13, 2019 •
edited
Loading

force push was for the linter with split lines

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2019
@techknowlogick techknowlogick merged commit 95d3d42 into go-gitea:master May 14, 2019
@mrsdizzie mrsdizzie mentioned this pull request Jun 28, 2019
Closed
7 tasks
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@xf- @jeffliu27
Fix code overflow (go-gitea#6914)
78aa9fc
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Provider config in Site Administration page breaks UI
8 participants
@xf- @codecov-io @lafriks @kolaente @zeripath @lunny @techknowlogick @GiteaBot