Skip to content

Fix input size for dependency select #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2019
Merged

Fix input size for dependency select #6913

merged 2 commits into from
May 12, 2019

Conversation

xf-
Copy link
Contributor

@xf- xf- commented May 11, 2019

fix #6884

Desktop
Screenshots
image

Tablet
image

Mobile
image

@xf-
Copy link
Contributor Author

xf- commented May 11, 2019

Doesn't include the build css

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 11, 2019
@xf- xf- force-pushed the bugfix/dependency branch from a228f7d to 912fb45 Compare May 11, 2019 22:50
@codecov-io
Copy link

codecov-io commented May 11, 2019 •
edited
Loading

Codecov Report

Merging #6913 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6913      +/-   ##
==========================================
- Coverage   41.42%   41.42%   -0.01%     
==========================================
  Files         440      440              
  Lines       59738    59738              
==========================================
- Hits        24749    24747       -2     
- Misses      31752    31754       +2     
  Partials     3237     3237
Impacted Files Coverage Δ
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13583a6...490a347. Read the comment docs.

@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels May 12, 2019
@lunny lunny added this to the 1.9.0 milestone May 12, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 12, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2019
@lafriks lafriks merged commit a92ab34 into go-gitea:master May 12, 2019
@lafriks
Copy link
Member

lafriks commented May 12, 2019

Please send backport to release/v1.8 branch

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

The width of dependencies select unit can not be changed when page radio changed.
6 participants
@xf- @codecov-io @lafriks @zeripath @lunny @GiteaBot