Do not attempt to return blob on submodule #6996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6996 +/- ##
=========================================
+ Coverage 41.49% 41.5% +0.01%
=========================================
Files 440 440
Lines 59453 59453
=========================================
+ Hits 24670 24676 +6
+ Misses 31563 31558 -5
+ Partials 3220 3219 -1
Continue to review full report at Codecov.
|
lafriks
approved these changes
May 19, 2019
|
@zeripath tests will be better. |
|
I really don't fancy trying to add tests for the compare endpoint. That would turn this one-line fix into a staggering behemoth, and I'd find and have to fix all of the rest of the bugs in compare. If I start down that path I'll end up rewriting the whole damned diff architecture. |
sapk
approved these changes
May 21, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6945 by not attempting to return a blob from a submodule.