Skip to content

Fix U2F for Chrome >= 74 #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2019
Merged

Fix U2F for Chrome >= 74 #6980

merged 1 commit into from
May 18, 2019

Conversation

daviian
Copy link
Member

@daviian daviian commented May 18, 2019

Resolves #6748

@daviian daviian changed the title Fix U2F for Chrome > 74 Fix U2F for Chrome >= 74 May 18, 2019
@codecov-io
Copy link

Codecov Report

Merging #6980 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6980      +/-   ##
==========================================
- Coverage   41.44%   41.43%   -0.01%     
==========================================
  Files         441      441              
  Lines       59696    59696              
==========================================
- Hits        24742    24737       -5     
- Misses      31729    31735       +6     
+ Partials     3225     3224       -1
Impacted Files Coverage Δ
models/u2f.go 63.15% <0%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/git/git.go 33.33% <0%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c385dcc...6974d40. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 18, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2019
zeripath
zeripath reviewed May 18, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh

@zeripath zeripath merged commit 8de76b6 into go-gitea:master May 18, 2019
@zeripath
Copy link
Contributor

Please send backport

daviian added a commit to daviian/gitea that referenced this pull request May 18, 2019
@daviian
fix u2f registrationlist ToRegistrations() method (go-gitea#6980)
c29db1c
@daviian daviian mentioned this pull request May 18, 2019
Merged
@daviian daviian deleted the fix/u2f-chrome74 branch May 18, 2019 13:51
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 18, 2019
techknowlogick pushed a commit that referenced this pull request May 18, 2019
@daviian @techknowlogick
fix u2f registrationlist ToRegistrations() method (#6980) (#6982)
895764e
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@daviian @jeffliu27
fix u2f registrationlist ToRegistrations() method (go-gitea#6980)
6ca9e7b
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

U2F doesn't work on Chrome 74
6 participants
@daviian @codecov-io @zeripath @lafriks @techknowlogick @GiteaBot