Refactor models.NewRepoContext to extract git related codes to modules/git #6941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6941 +/- ##
==========================================
+ Coverage 41.39% 41.41% +0.01%
==========================================
Files 441 441
Lines 59732 59718 -14
==========================================
+ Hits 24729 24730 +1
+ Misses 31764 31753 -11
+ Partials 3239 3235 -4
Continue to review full report at Codecov.
|
kolaente
reviewed
May 14, 2019
routers/admin/admin.go
Outdated
| @@ -210,7 +211,8 @@ func Config(ctx *context.Context) { | |||
| ctx.Data["DisableRouterLog"] = setting.DisableRouterLog | |||
| ctx.Data["RunUser"] = setting.RunUser | |||
| ctx.Data["RunMode"] = strings.Title(macaron.Env) | |||
| ctx.Data["GitVersion"] = setting.Git.Version | |||
| ver, _ := git.BinVersion() | |||
| ctx.Data["GitVersion"] = ver | |||
There was a problem hiding this comment.
I think you could do this in one line.
b2392d5 to
551b500
Compare
zeripath
reviewed
May 14, 2019
| @@ -931,6 +932,8 @@ func NewContext() { | |||
| sec = Cfg.Section("U2F") | |||
| U2F.TrustedFacets, _ = shellquote.Split(sec.Key("TRUSTED_FACETS").MustString(strings.TrimRight(AppURL, "/"))) | |||
| U2F.AppID = sec.Key("APP_ID").MustString(strings.TrimRight(AppURL, "/")) | |||
|
|
|||
| zip.Verbose = false | |||
There was a problem hiding this comment.
Do we still need this? I'm not sure we use cae/zip elsewhere.
There was a problem hiding this comment.
Don't know. Since this is a refactor PR, I just keep it.
zeripath
approved these changes
May 14, 2019
mrsdizzie
approved these changes
May 14, 2019
kolaente
approved these changes
May 14, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
…s/git (go-gitea#6941) * refactor models.NewRepoContext to extract git related codes to modules/git * fix imports * refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.