Skip to content

Conversation

sapk
Copy link
Member

@sapk sapk commented May 2, 2019

From un-tagged previous version : urfave/cli@d86a009...master

Mostly little improvement on handling errors.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 2, 2019
@codecov-io
Copy link

codecov-io commented May 2, 2019

Codecov Report

Merging #6838 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6838      +/-   ##
==========================================
+ Coverage   41.22%   41.23%   +<.01%     
==========================================
  Files         421      421              
  Lines       58125    58125              
==========================================
+ Hits        23962    23965       +3     
+ Misses      30991    30987       -4     
- Partials     3172     3173       +1
Impacted Files Coverage Δ
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb0c96...02119f0. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2019
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 3, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone May 3, 2019
@techknowlogick techknowlogick merged commit 2933ae4 into go-gitea:master May 3, 2019
@sapk sapk deleted the updt-urfave-cli branch May 4, 2019 20:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants