When mirroring we should set the remote to mirror #6824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
May 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #6824 +/- ##
==========================================
- Coverage 41.22% 41.21% -0.01%
==========================================
Files 421 421
Lines 58118 58118
==========================================
- Hits 23958 23955 -3
- Misses 30987 30990 +3
Partials 3173 3173
Continue to review full report at Codecov.
|
mrsdizzie
approved these changes
May 1, 2019
lafriks
approved these changes
May 2, 2019
|
Please send backport |
|
Can do that this evening in 10 hours time, but if wanted earlier feel free. |
|
Backport made. |
techknowlogick
pushed a commit
that referenced
this pull request
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fix in #6593 didn't set the mirrors to be mirrors for fetching, which appears to have broken mirroring.
When adding the remote we should --mirror=fetch to set the refs correctly.
Fix #6783