Change verbose flag in dump command to avoid colliding with global version flag #6822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
|
Can you update docs as well? Does this need to be backported? |
|
No need to backport since it was introduced with #6631 which is new to 1.9 |
Signed-off-by: jolheiser <john.olheiser@gmail.com>
|
@techknowlogick Done, I did a quick search and only found it referenced once in docs. If someone knows of another place let me know, but searching for |
Codecov Report
@@ Coverage Diff @@
## master #6822 +/- ##
==========================================
+ Coverage 41.21% 41.21% +<.01%
==========================================
Files 421 421
Lines 58118 58118
==========================================
+ Hits 23951 23956 +5
+ Misses 30994 30990 -4
+ Partials 3173 3172 -1
Continue to review full report at Codecov.
|
zeripath
approved these changes
May 1, 2019
|
Sorry peeps for introducing that bug! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
Fixes #6821