Skip to content

SearchRepositoryByName improvements and unification #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 15, 2019
Merged

SearchRepositoryByName improvements and unification #6897

merged 12 commits into from
May 15, 2019

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 9, 2019 •
edited
Loading

This PR improves SearchRepositoryByName to return repositories that are accessible to the current user and returns public repositories that a user is a member of a team of.

Fixes #5454
Fixes #6670
Fixes #6195

Likely some others too

@zeripath
Copy link
Contributor Author

zeripath commented May 9, 2019

Fixes #6670

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2019
@codecov-io
Copy link

codecov-io commented May 9, 2019 •
edited
Loading

Codecov Report

Merging #6897 into master will increase coverage by 0.06%.
The diff coverage is 92.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6897      +/-   ##
==========================================
+ Coverage   41.41%   41.47%   +0.06%     
==========================================
  Files         441      441              
  Lines       59724    59663      -61     
==========================================
+ Hits        24732    24745      +13     
+ Misses      31755    31695      -60     
+ Partials     3237     3223      -14
Impacted Files Coverage Δ
models/repo_list.go 72.08% <100%> (+5.23%) ⬆️
routers/api/v1/repo/repo.go 57.03% <100%> (+1.43%) ⬆️
routers/user/home.go 53.28% <78.57%> (+3.39%) ⬆️
routers/user/profile.go 50.48% <81.25%> (+12.39%) ⬆️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
models/org.go 69.77% <0%> (-0.96%) ⬇️
models/repo.go 47.27% <0%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb1ad7...9ac2f63. Read the comment docs.

sapk
sapk reviewed May 10, 2019
View reviewed changes
@lunny lunny added the type/enhancement An improvement of existing functionality label May 10, 2019
@lunny lunny added this to the 1.9.0 milestone May 10, 2019
lafriks
lafriks requested changes May 10, 2019
View reviewed changes
zeripath
zeripath commented May 10, 2019
View reviewed changes
@zeripath zeripath mentioned this pull request May 13, 2019
Closed
7 tasks
@zeripath zeripath requested review from lafriks and sapk May 13, 2019 11:31
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 15, 2019
@mrsdizzie
Copy link
Member

👍 tested for a while and fixes all of those linked issues thanks much!

@techknowlogick techknowlogick merged commit 56ae539 into go-gitea:master May 15, 2019
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request May 20, 2019
@zeripath @lafriks
SearchRepositoryByName improvements and unification (go-gitea#6897)
ed34110
@lafriks lafriks mentioned this pull request May 20, 2019
Closed
7 tasks
@zeripath zeripath deleted the fix-#5454-improve-api-repos-search branch May 20, 2019 13:33
@lassebm
Copy link

lassebm commented May 20, 2019

@techknowlogick Please consider backporting to 1.8. Thanks.

zeripath added a commit to zeripath/gitea that referenced this pull request May 20, 2019
@zeripath
SearchRepositoryByName improvements and unification (go-gitea#6897)
eb2e7db
@lafriks lafriks mentioned this pull request May 20, 2019
Merged
@lafriks lafriks added backport/done All backports for this PR have been created backport/v1.8 labels May 20, 2019
lafriks added a commit that referenced this pull request May 21, 2019
@lafriks
SearchRepositoryByName improvements and unification (#6897) (#7002)
608f46e 
* SearchRepositoryByName improvements and unification (#6897)

* Update tests

Co-Authored-By: zeripath <art27@cantab.net>

* Update tests

Co-Authored-By: zeripath <art27@cantab.net>

* Update tests

Co-Authored-By: zeripath <art27@cantab.net>

* Fix tests
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@zeripath @jeffliu27
SearchRepositoryByName improvements and unification (go-gitea#6897)
7c0b7a8
@zeripath zeripath mentioned this pull request Oct 16, 2019
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@sapk sapk Awaiting requested review from sapk

+1 more reviewer

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
9 participants
@zeripath @codecov-io @mrsdizzie @lassebm @lafriks @sapk @lunny @techknowlogick @GiteaBot