Skip to content

Improve localization of git activity stats #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2019
Merged

Improve localization of git activity stats #6848

merged 1 commit into from
May 4, 2019

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 4, 2019

As per comments on previous PR

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 4, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 4, 2019
@lafriks lafriks mentioned this pull request May 4, 2019
Merged
4 tasks
@ngourdon
Copy link
Contributor

ngourdon commented May 4, 2019

LGTM

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #6848 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6848      +/-   ##
==========================================
+ Coverage   41.18%   41.19%   +0.01%     
==========================================
  Files         423      423              
  Lines       58394    58394              
==========================================
+ Hits        24048    24056       +8     
+ Misses      31167    31159       -8     
  Partials     3179     3179
Impacted Files Coverage Δ
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46373e7...edda4be. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2019
@lafriks lafriks merged commit 410301f into go-gitea:master May 4, 2019
@lafriks lafriks deleted the fix/git_activity_tr branch May 4, 2019 20:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lafriks @ngourdon @codecov-io @zeripath @sapk @GiteaBot