Skip to content

Stricter domain name pattern in email regex #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2019
Merged

Stricter domain name pattern in email regex #6739

merged 2 commits into from
Apr 25, 2019

Conversation

mrsdizzie
Copy link
Member

Fixes #6735

@codecov-io
Copy link

codecov-io commented Apr 24, 2019 •
edited
Loading

Codecov Report

Merging #6739 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6739      +/-   ##
==========================================
- Coverage      41%   40.98%   -0.02%     
==========================================
  Files         421      421              
  Lines       57915    57915              
==========================================
- Hits        23746    23735      -11     
- Misses      31010    31021      +11     
  Partials     3159     3159
Impacted Files Coverage Δ
modules/markup/html.go 81% <ø> (ø) ⬆️
models/unit.go 45.71% <0%> (-5.72%) ⬇️
models/repo_indexer.go 66.52% <0%> (-1.28%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 41.6% <0%> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a58832...62d5b0d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2019
@techknowlogick techknowlogick merged commit 0064535 into go-gitea:master Apr 25, 2019
@lunny
Copy link
Member

lunny commented Apr 25, 2019

Please send backport to release/v1.8

@mrsdizzie
Copy link
Member Author

This can't be cherry picked because of 6293736 which also changes this line. Want me to create a separate commit on release/v1.8 that just does the same thing?

@techknowlogick
Copy link
Member

@mrsdizzie yes please

mrsdizzie added a commit to mrsdizzie/gitea that referenced this pull request Apr 26, 2019
@mrsdizzie
Stricter domain name pattern in email regex
feacc43 
Backport of go-gitea#6739
@mrsdizzie mrsdizzie mentioned this pull request Apr 26, 2019
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Apr 26, 2019
lafriks pushed a commit that referenced this pull request Apr 26, 2019
@mrsdizzie @lafriks
Stricter domain name pattern in email regex (#6768)
8b3aad9 
Backport of #6739
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

E-Mail address detection should validate domain name part
7 participants
@mrsdizzie @codecov-io @lunny @techknowlogick @lafriks @zeripath @GiteaBot