Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 24, 2019

Add tests for #5603

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #6731 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6731      +/-   ##
==========================================
+ Coverage   40.72%   40.82%   +0.09%     
==========================================
  Files         421      421              
  Lines       57902    57902              
==========================================
+ Hits        23582    23637      +55     
+ Misses      31186    31126      -60     
- Partials     3134     3139       +5
Impacted Files Coverage Δ
routers/api/v1/api.go 68.68% <0%> (+0.63%) ⬆️
routers/repo/view.go 42.6% <0%> (+1%) ⬆️
models/unit.go 51.42% <0%> (+5.71%) ⬆️
routers/api/v1/org/org.go 51.61% <0%> (+10.32%) ⬆️
routers/api/v1/org/member.go 12.13% <0%> (+12.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d8ea9...938ef2e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2019
@techknowlogick techknowlogick merged commit 1d8b521 into go-gitea:master Apr 24, 2019
@lunny lunny deleted the lunny/org_api branch April 24, 2019 16:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Feb 25, 2025
The button to insert an URL now opens a dialog prompting for the two
components, the URL and the description.
Any existing text selection is taken into account to pre-fill the
description field.

Closes: go-gitea#6731

![image](/attachments/ca1f7767-5fd6-4c38-8c7a-83d893523de2)

Co-authored-by: Otto Richter <otto@codeberg.org>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7006
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: Lucas Schwiderski <lucas@lschwiderski.de>
Co-committed-by: Lucas Schwiderski <lucas@lschwiderski.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants