Skip to content

Fix team members API #6714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 24, 2019
Merged

Fix team members API #6714

merged 7 commits into from
Apr 24, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 23, 2019

will fix #6704

@lunny lunny added the type/bug label Apr 23, 2019
@lunny lunny added this to the 1.9.0 milestone Apr 23, 2019
@zeripath
Copy link
Contributor

Integration tests need to be updated

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 23, 2019
lafriks
lafriks reviewed Apr 23, 2019
View reviewed changes
@lunny lunny force-pushed the lunny/fix_teams branch from 82e9285 to da3c1c0 Compare April 24, 2019 03:31
@codecov-io
Copy link

codecov-io commented Apr 24, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e0172f0). Click here to learn what that means.
The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6714   +/-   ##
=========================================
  Coverage          ?   40.73%           
=========================================
  Files             ?      421           
  Lines             ?    57902           
  Branches          ?        0           
=========================================
  Hits              ?    23585           
  Misses            ?    31184           
  Partials          ?     3133
Impacted Files Coverage Δ
routers/api/v1/api.go 68.04% <30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0172f0...eadb22a. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2019
mrsdizzie
mrsdizzie reviewed Apr 24, 2019
View reviewed changes
@mrsdizzie @lunny
Update routers/api/v1/api.go
36b45c9 
Co-Authored-By: lunny <xiaolunwen@gmail.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2019
@techknowlogick techknowlogick merged commit 59be704 into go-gitea:master Apr 24, 2019
@techknowlogick techknowlogick changed the title fix team members API Fix team members API Apr 24, 2019
@techknowlogick
Copy link
Member

@lunny please backport 😄

@lunny lunny deleted the lunny/fix_teams branch April 24, 2019 05:33
lunny added a commit to lunny/gitea that referenced this pull request Apr 24, 2019
@lunny
Fix team members API (go-gitea#6714)
2f8932c
@lunny lunny mentioned this pull request Apr 24, 2019
Merged
@lunny
Copy link
Member Author

lunny commented Apr 24, 2019

@techknowlogick done.

@lunny lunny added the backport/done All backports for this PR have been created label Apr 24, 2019
lunny added a commit that referenced this pull request Apr 24, 2019
@lunny
Fix team members API (#6714) (#6729)
5f6b118
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Members of a team in org can view detail of other teams (in the same org) via api
7 participants
@lunny @zeripath @codecov-io @techknowlogick @lafriks @mrsdizzie @GiteaBot