Skip to content

Restore IsWindows variable assignment (#6722) #6790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2019
Merged

Restore IsWindows variable assignment (#6722) #6790

merged 1 commit into from
Apr 28, 2019

Conversation

scottaglia
Copy link
Contributor

Fixes #6722

@scottaglia
Restore IsWindows variable assignment (go-gitea#6722)
c0acf99 
Signed-off-by: Nicola Scattaglia <scattaglia.nicola.work@gmail.com>
@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #6790 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6790      +/-   ##
==========================================
+ Coverage   41.22%   41.22%   +<.01%     
==========================================
  Files         421      421              
  Lines       58054    58055       +1     
==========================================
+ Hits        23931    23934       +3     
+ Misses      30957    30955       -2     
  Partials     3166     3166
Impacted Files Coverage Δ
modules/setting/setting.go 48.26% <100%> (+0.09%) ⬆️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29d97d...c0acf99. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2019
@lafriks lafriks merged commit cde6079 into go-gitea:master Apr 28, 2019
@lafriks
Copy link
Member

lafriks commented Apr 28, 2019

Please send backport to 1.8 branch

@scottaglia
Copy link
Contributor Author

It looks like the lines added in this PR are already in the 1.8 branch
https://github.com/go-gitea/gitea/blob/release/v1.8/modules/setting/setting.go#L403

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Gitea not starting as Windows service
7 participants
@scottaglia @codecov-io @lafriks @adelowo @jolheiser @techknowlogick @GiteaBot