Skip to content

Service worker js is a missing comma #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2019
Merged

Service worker js is a missing comma #6788

merged 2 commits into from
Apr 29, 2019

Conversation

techknowlogick
Copy link
Member

Fix #6787

@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 28, 2019
@codecov-io
Copy link

codecov-io commented Apr 28, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3d26b3f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6788   +/-   ##
=========================================
  Coverage          ?   41.21%           
=========================================
  Files             ?      421           
  Lines             ?    58055           
  Branches          ?        0           
=========================================
  Hits              ?    23930           
  Misses            ?    30959           
  Partials          ?     3166

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d26b3f...f6e1565. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2019
@dmolik
Copy link
Contributor

dmolik commented Apr 28, 2019

👍

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2019
@techknowlogick techknowlogick merged commit 9a838cf into go-gitea:master Apr 29, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-2 branch April 29, 2019 01:45
@techknowlogick techknowlogick mentioned this pull request Apr 29, 2019
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Apr 29, 2019
techknowlogick added a commit that referenced this pull request Apr 29, 2019
@techknowlogick
Service worker js is a missing comma (#6788) (#6795)
98d82a7
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Service worker js is a missing comma
6 participants
@techknowlogick @codecov-io @dmolik @lafriks @mrsdizzie @GiteaBot