Skip to content

Use modules/git for git commands #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2019
Merged

Use modules/git for git commands #6775

merged 2 commits into from
May 13, 2019

Conversation

typeless
Copy link
Contributor

@typeless typeless commented Apr 27, 2019 •
edited
Loading

Updating them incrementally.

@codecov-io
Copy link

codecov-io commented Apr 27, 2019 •
edited
Loading

Codecov Report

Merging #6775 into master will decrease coverage by 0.02%.
The diff coverage is 7.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6775      +/-   ##
==========================================
- Coverage   41.42%   41.39%   -0.03%     
==========================================
  Files         440      440              
  Lines       59744    59703      -41     
==========================================
- Hits        24746    24715      -31     
+ Misses      31761    31751      -10     
  Partials     3237     3237
Impacted Files Coverage Δ
models/pull.go 49.71% <7.31%> (-1.89%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffc965...ba97433. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2019
@typeless typeless changed the title [WIP] Use modules/git for git commands Use modules/git for git commands Apr 27, 2019
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 27, 2019
@lunny lunny added this to the 1.9.0 milestone Apr 27, 2019
@lunny
Copy link
Member

lunny commented Apr 27, 2019

I found there are 38 revokes to process.GetManager().ExecDir.

@lunny lunny added the pr/wip This PR is not ready for review label Apr 27, 2019
@typeless
Copy link
Contributor Author

@lunny I don't intend to do all replacements in one PR.

@lunny lunny removed the pr/wip This PR is not ready for review label Apr 30, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2019
@zeripath
Copy link
Contributor

zeripath commented May 8, 2019

Please take a look at #6672 I moved some commands in to modules/git there and also made hooks run on pushes.

@zeripath
Copy link
Contributor

Sorry looks like I've caused conflicts

@typeless typeless force-pushed the using-git-command-module branch from d3215a0 to 108e751 Compare May 13, 2019 02:14
@typeless
Copy link
Contributor Author

@zeripath never mind. PTAL when CI finished.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2019
@techknowlogick techknowlogick merged commit 0b78548 into go-gitea:master May 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@kolaente kolaente kolaente approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
8 participants
@typeless @codecov-io @lunny @zeripath @lafriks @kolaente @techknowlogick @GiteaBot