Skip to content

Move PushUpdate dependency from models to repofiles #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2019
Merged

Move PushUpdate dependency from models to repofiles #6763

merged 3 commits into from
Jun 10, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 26, 2019

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 26, 2019
@lunny lunny added this to the 1.9.0 milestone Apr 26, 2019
@lunny lunny changed the title move PushUpdate dependency from models to repofiles Move PushUpdate dependency from models to repofiles Apr 26, 2019
@lafriks
Copy link
Member

lafriks commented Apr 26, 2019

Drone fail

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 26, 2019
@lunny lunny force-pushed the lunny/indexer_notify branch 2 times, most recently from 5b38fb3 to a94d140 Compare May 14, 2019 12:05
@lunny lunny force-pushed the lunny/indexer_notify branch from a94d140 to f5fed3b Compare May 24, 2019 06:01
@codecov-io
Copy link

codecov-io commented May 24, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b1be6fd). Click here to learn what that means.
The diff coverage is 33.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6763   +/-   ##
=========================================
  Coverage          ?   41.74%           
=========================================
  Files             ?      449           
  Lines             ?    61111           
  Branches          ?        0           
=========================================
  Hits              ?    25511           
  Misses            ?    32286           
  Partials          ?     3314
Impacted Files Coverage Δ
models/update.go 46.93% <ø> (ø)
modules/repofiles/upload.go 0% <0%> (ø)
routers/private/push_update.go 0% <0%> (ø)
modules/repofiles/delete.go 53.84% <100%> (ø)
routers/private/hook.go 47.67% <22.22%> (ø)
modules/repofiles/update.go 40.06% <72.72%> (ø)
routers/repo/branch.go 58.51% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1be6fd...9a39c39. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented May 24, 2019

Ready for review.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 24, 2019
@lunny lunny force-pushed the lunny/indexer_notify branch from 9b08be2 to 23a949b Compare June 6, 2019 06:07
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2019
@lunny lunny merged commit d93e623 into go-gitea:master Jun 10, 2019
@lunny lunny deleted the lunny/indexer_notify branch June 10, 2019 11:48
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Move PushUpdate dependency from models to repofiles (go-gitea#6763)
4fc886f 
* remove push_update

* move models.PushUpdate to repofiles.PushUpdate
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@BetaCat0 BetaCat0 BetaCat0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @lafriks @codecov-io @BetaCat0 @GiteaBot