Skip to content

fix missing return #6751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2019
Merged

fix missing return #6751

merged 2 commits into from
Apr 25, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 25, 2019

No description provided.

@lunny lunny added this to the 1.9.0 milestone Apr 25, 2019
@lunny lunny requested a review from jonasfranz April 25, 2019 08:31
@codecov-io
Copy link

codecov-io commented Apr 25, 2019 •
edited
Loading

Codecov Report

Merging #6751 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6751      +/-   ##
==========================================
- Coverage   40.99%   40.98%   -0.01%     
==========================================
  Files         421      421              
  Lines       57933    57934       +1     
==========================================
- Hits        23748    23744       -4     
- Misses      31026    31031       +5     
  Partials     3159     3159
Impacted Files Coverage Δ
routers/user/oauth.go 43.86% <0%> (-0.14%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
routers/repo/view.go 41.6% <0%> (-1.01%) ⬇️
models/gpg_key.go 54.72% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b3f51...b0dc634. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2019
@lunny lunny merged commit e8f4c77 into go-gitea:master Apr 25, 2019
@lunny lunny deleted the lunny/fix_miss_return branch April 25, 2019 11:30
lunny added a commit to lunny/gitea that referenced this pull request Apr 25, 2019
@lunny
fix missing return (go-gitea#6751)
32af229
@lunny lunny mentioned this pull request Apr 25, 2019
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Apr 25, 2019
techknowlogick pushed a commit that referenced this pull request Apr 25, 2019
@lunny @techknowlogick
fix missing return (#6751) (#6756)
30226b4
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jonasfranz jonasfranz Awaiting requested review from jonasfranz

+1 more reviewer

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @lafriks @adelowo @GiteaBot