Skip to content

Conversation

MayMeow
Copy link
Contributor

@MayMeow MayMeow commented Apr 15, 2019

I updated ui for topics labels. Now labels are smaller with bottom margin on projects list which is missing in current version.

fixing #6621

@jolheiser
Copy link
Member

Can you provide any screenshots for reference? 😃
(I know it's a small change, but it's nice to be able to refer to before/after images)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 15, 2019
@techknowlogick
Copy link
Member

@jolheiser please see linked ticket for screenshots.

@jolheiser
Copy link
Member

🤦‍♂️ Thanks

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #6639 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6639      +/-   ##
==========================================
+ Coverage   40.53%   40.54%   +<.01%     
==========================================
  Files         406      406              
  Lines       54492    54492              
==========================================
+ Hits        22090    22093       +3     
+ Misses      29365    29362       -3     
  Partials     3037     3037
Impacted Files Coverage Δ
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8371168...65b184a. Read the comment docs.

@MayMeow
Copy link
Contributor Author

MayMeow commented Apr 15, 2019

adding some screenshots how it is looks now from localhost

Project list

Screenshot from 2019-04-15 20-17-40

Project detail

Screenshot from 2019-04-15 20-17-57

Running version you can check here https://git.maymeow.red/explore/repos

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 15, 2019
@techknowlogick techknowlogick merged commit 83d6e5e into go-gitea:master Apr 15, 2019
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 17, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 17, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants