Add support for MS Teams webhooks #6632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also add MS Teams comparison Signed-off-by: Daniel Grier <daniel.grier@gmail.com>
Signed-off-by: Daniel Grier <daniel.grier@gmail.com>
Signed-off-by: Daniel Grier <daniel.grier@gmail.com>
Signed-off-by: Daniel Grier <daniel.grier@gmail.com>
…ms-webhook Signed-off-by: Daniel Grier <daniel.grier@gmail.com>
lunny
reviewed
Apr 15, 2019
Signed-off-by: Daniel Grier <daniel.grier@gmail.com>
Signed-off-by: Daniel Grier <daniel.grier@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6632 +/- ##
==========================================
- Coverage 41.35% 40.87% -0.49%
==========================================
Files 415 416 +1
Lines 56337 57013 +676
==========================================
+ Hits 23299 23303 +4
- Misses 29917 30589 +672
Partials 3121 3121
Continue to review full report at Codecov.
|
|
Is there anything else needed for approval? |
|
@dangrier could you resolve git conflicts, and post screenshots of what a webhook would look like in MS Teams? |
|
@dangrier I've just resolved the git conflicts. I did it via Github interface so hopefully a |
|
Okay, didn't see that so also resolved - but not to worry! It looks like this: |
techknowlogick
approved these changes
Apr 19, 2019
|
@dangrier ah phew. glad that was quick to diagnose. |
lafriks
approved these changes
Apr 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5964 to add Microsoft Teams webhooks (Incoming Webhook Connector).
Largely matched styling of Discord webhooks and aligned with other webhook functionality/appearance.
Tested on a local instance, with a connection to Teams and functioned as expected.
All commits signed off, and latest changes integrated from upstream.