Return a UserList from /api/v1/admin/users #6629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
How about make a function |
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
And any test for this API is better! |
Codecov Report
@@ Coverage Diff @@
## master #6629 +/- ##
==========================================
+ Coverage 40.47% 40.52% +0.05%
==========================================
Files 406 406
Lines 54484 54492 +8
==========================================
+ Hits 22052 22084 +32
+ Misses 29395 29372 -23
+ Partials 3037 3036 -1
Continue to review full report at Codecov.
|
sapk
approved these changes
Apr 15, 2019
adelowo
approved these changes
Apr 15, 2019
|
But CI build failed. |
|
Sigh sorry about that. |
|
@zeripath merged 😃 please backport. |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 15, 2019
techknowlogick
pushed a commit
that referenced
this pull request
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new /api/v1/admin/users endpoint doesn't return a UserList as described on swagger and doesn't return
api.Userbut rather an unsanitised form ofmodels.User.This PR fixes this.