Trace Logging on Permission Denied & ColorFormat #6618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structs can now implement log.ColorFormatted to provide their own colored format when logged with `%-v` or additional flags. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #6618 +/- ##
==========================================
- Coverage 40.79% 40.73% -0.07%
==========================================
Files 421 421
Lines 57570 57866 +296
==========================================
+ Hits 23487 23569 +82
- Misses 30955 31168 +213
- Partials 3128 3129 +1
Continue to review full report at Codecov.
|
7 tasks
lunny
reviewed
Apr 15, 2019
Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
approved these changes
Apr 16, 2019
|
Isn't |
|
Ah yes but constructing the trace call is not free - so if we can avoid constructing it at all that may make sense. A lot of the calls there are less complex than I originally had them because I moved functionality into colorformat, so we could remove a few of the IsTrace calls but not all |
adelowo
approved these changes
Apr 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
log.Trace(...)calls to Permission Denied events.It also adds a new additional way for providing colored logs for structs in a semi-standardised way. e.g.
Will log
Log me a user userID:usernamewith the userID being colored cyan and the username in bold.Structs that want to implement this need to provide a
ColorFormat(s fmt.State)function which is very similar to theFormat(...)function expected byfmt(mainly lacking the rune - which would always be'v'.) If you logged%-vthen this function will be called, and if more verbose output is possible a+should be passed in the flags and inspected for withs.Flags('+')inColorFormat, e.g.log.Info("%-+v", perm)to log a verbose version ofmodels.Permission.