add .gpg url (match github behaviour) #6610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sapk Thanks for continuing this PR 😃 |
Co-Authored-By: sapk <sapk@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #6610 +/- ##
==========================================
+ Coverage 40.47% 40.48% +<.01%
==========================================
Files 405 406 +1
Lines 54388 54484 +96
==========================================
+ Hits 22012 22056 +44
- Misses 29349 29390 +41
- Partials 3027 3038 +11
Continue to review full report at Codecov.
|
|
@sapk @techknowlogick good work. With integration tests are better. |
|
@lunny done |
lunny
approved these changes
Apr 14, 2019
techknowlogick
approved these changes
Apr 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing of #4193 I added what was missing to have it working. Thx to @techknowlogick that lay down most of the bases.
Basically, we haven't in database what is needed to fully reconstruct the gpg armored export (ex: signature, full identities, ...).
I add a table containing the imported armored key that we can re-used to be join with others imported keys and exported.
Like github previous keys that need re-import are marked as a header (ex: https://github.com/sapk.gpg)
The only bug is that the cipherTypeByte are changed by the export by golang compared to the imported one but that doesn't change the interpretation of the gpg armored key.